Skip to content

[HttpFoundation] update doc creation session table #17844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alli83
Copy link
Contributor

@alli83 alli83 commented Feb 1, 2023

linked to issue #17569 and PR https://github.com/symfony/symfony/pull/49097/files

Update the methods to create the session table.

@stof
Copy link
Member

stof commented May 22, 2023

this change is correct but it is not specific to databases. Passing a DSN as handler_id is supported in Symfony 4.4+ and supports other kinds of handlers too (if you pass a redis:// URL, it will create a redis handler).
See symfony/symfony#34177 for the PR implementing it and #13227 for the PR documenting it.
So I'm not sure this should be repeated in this code snippet.

IMO, this PR should focus only on the issue it attempts to fix, i.e. documenting the integration with the doctrine schema tool.

@alli83
Copy link
Contributor Author

alli83 commented May 23, 2023

@stof I see, thanks for your feedback ! I'll update it

@alli83 alli83 force-pushed the http-foundation-creation-session-table branch from 6f33b44 to ace8e03 Compare May 24, 2023 20:21
@javiereguiluz javiereguiluz merged commit fee22ab into symfony:6.3 May 25, 2023
@javiereguiluz
Copy link
Member

@alli83 thanks a lot for improving the docs and congrats on your first Symfony Docs contribution 🎉

Thanks also to Christophe for reviewing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants