Skip to content

[Security] Add argument $exceptionCode to #[IsGranted] #18101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

[Security] Add argument $exceptionCode to #[IsGranted] #18101

merged 1 commit into from
Mar 21, 2023

Conversation

alexandre-daubois
Copy link
Member

Fixes #18097

@carsonbot carsonbot added this to the 6.3 milestone Mar 20, 2023
@WebMamba
Copy link
Contributor

WebMamba commented Mar 20, 2023 •
edited
Loading

I think we should also add something about the statusCode argument. I am not sure we have something about it

@alexandre-daubois alexandre-daubois mentioned this pull request Mar 20, 2023
Closed
@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Mar 20, 2023 •
edited
Loading

@WebMamba Good idea! This must be done in 6.2. Here you are 🙂 ! #18103

@OskarStark
Copy link
Contributor

#18103 should be merged first

OskarStark added a commit that referenced this pull request Mar 21, 2023
@OskarStark
minor #18103 [Security] Add statusCode and message arguments to `…
f9442fd 
…#[IsGranted]` (alexandre-daubois)

This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

[Security] Add `statusCode` and `message` arguments to `#[IsGranted]`

Following #18101 (comment)

Commits
-------

149d33b [Security] Add `statusCode` and `message` arguments to `#[IsGranted]`
@OskarStark
Copy link
Contributor

Rebase unlocked ✅

@alexandre-daubois
Copy link
Member Author

Rebased and updated 🙏

@javiereguiluz javiereguiluz merged commit 6009b8f into symfony:6.3 Mar 21, 2023
@javiereguiluz
Copy link
Member

Thanks Alex for contributing this in two different PR and for rebasing and updating as needed 🙏

@javiereguiluz javiereguiluz mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandre-daubois @WebMamba @OskarStark @javiereguiluz @carsonbot