Skip to content

[Filesystem] remove unused makeRelative example #19107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2023
Merged

[Filesystem] remove unused makeRelative example #19107

merged 1 commit into from
Nov 13, 2023

Conversation

devojifr
Copy link
Contributor

@devojifr devojifr commented Nov 2, 2023

To illustrate getLongestCommonBasePath() usage, a makeRelative example is mentioned but not used.

@carsonbot carsonbot added this to the 5.4 milestone Nov 2, 2023
@javiereguiluz
Copy link
Member

Yes, this way is better. Thanks @devojifr

@javiereguiluz javiereguiluz merged commit fc6f187 into symfony:5.4 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Filesystem Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@devojifr @javiereguiluz @carsonbot