[VarExporter] Deprecate per-property lazy-initializers #19132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
deprecate-lazyghost-array-initializer
branch
from
74945cf to
9510391
Compare
|
Rebase unlocked ✅ |
alexandre-daubois
force-pushed
the
deprecate-lazyghost-array-initializer
branch
from
9510391 to
49ac88d
Compare
|
Rebase achieved ✔️ |
OskarStark
reviewed
Nov 14, 2023
components/var_exporter.rst
Outdated
| { | ||
| // Compute $this->hash value with the passed data | ||
| } | ||
| } | ||
|
|
||
| .. deprecated:: 6.4 | ||
|
|
||
| Using an array of closure for property-based initialization in the |
There was a problem hiding this comment.
Suggested change
| Using an array of closure for property-based initialization in the | |
| Using an array of closures for property-based initialization in the |
There was a problem hiding this comment.
Good catch, thank you
alexandre-daubois
force-pushed
the
deprecate-lazyghost-array-initializer
branch
from
49ac88d to
d17116a
Compare
|
Nice one! Thanks Alex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19131
Renamed from
computeHashtopopulateHashand changed return type tovoidto better reflect an initializer at object-level.