Skip to content

[VarExporter] Deprecate per-property lazy-initializers #19132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Nov 14, 2023

Fix #19131

Renamed from computeHash to populateHash and changed return type to void to better reflect an initializer at object-level.

@carsonbot carsonbot added this to the 6.4 milestone Nov 14, 2023
@alexandre-daubois alexandre-daubois force-pushed the deprecate-lazyghost-array-initializer branch from 74945cf to 9510391 Compare November 14, 2023 09:02
@OskarStark
Copy link
Contributor

Rebase unlocked ✅

@alexandre-daubois alexandre-daubois force-pushed the deprecate-lazyghost-array-initializer branch from 9510391 to 49ac88d Compare November 14, 2023 09:30
@alexandre-daubois
Copy link
Member Author

Rebase achieved ✔️

{
// Compute $this->hash value with the passed data
}
}

.. deprecated:: 6.4

Using an array of closure for property-based initialization in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Using an array of closure for property-based initialization in the
Using an array of closures for property-based initialization in the

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you

@javiereguiluz
Copy link
Member

Nice one! Thanks Alex.

@javiereguiluz javiereguiluz merged commit 2f62ecc into symfony:6.4 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VarExporter] Deprecate per-property lazy-initializers
4 participants