[Runtime] Update runtime.rst #19219
Merged
[Runtime] Update runtime.rst #19219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo PHP-PM:PHP-FPM
|
Good catch @morrsky! Thanks and congrats on your first Symfony Docs contribution! |
javiereguiluz
force-pushed
the
patch-1
branch
from
bcbbdcc to
8962ac5
Compare
xabbuh
reviewed
Dec 5, 2023
| @@ -2,7 +2,7 @@ The Runtime Component | |||
| ===================== | |||
|
|
|||
| The Runtime Component decouples the bootstrapping logic from any global state | |||
| to make sure the application can run with runtimes like PHP-PM, ReactPHP, | |||
| to make sure the application can run with runtimes like PHP-FPM, ReactPHP, | |||
There was a problem hiding this comment.
I think this change is wrong and PHP-PM refers to the PHP Process Manager.
There was a problem hiding this comment.
@Nyholm Can you help here as you contributed the initial version of this document?
There was a problem hiding this comment.
Correct, It is meant to say PHP-PM.
There was a problem hiding this comment.
see #19221 where I try to clarify this by adding links to these projects
There was a problem hiding this comment.
Sorry about this! I just merged your PR fixing this.
javiereguiluz
added a commit
that referenced
this pull request
Dec 5, 2023
This PR was merged into the 5.4 branch. Discussion ---------- fix the Runtime component introduction see #19219 (comment) Commits ------- 817c172 fix the Runtime component introduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typo PHP-PM:PHP-FPM