[Webhook] Added Sendgrid's webhook support (added in 6.4) #19267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Dec 12, 2023
| @@ -84,8 +84,14 @@ Mailer service Parser service name | |||
| =============== ========================================== | |||
| Mailgun ``mailer.webhook.request_parser.mailgun`` | |||
| Postmark ``mailer.webhook.request_parser.postmark`` | |||
| Sendgrid ``mailer.webhook.request_parser.sendgrid`` | |||
| =============== ========================================== | |||
|
|
|||
There was a problem hiding this comment.
We should add a versionadded for Mailgun and Postmark too
There was a problem hiding this comment.
As a third column, perhaps? To have a bit better overview when more are added in the future?
There was a problem hiding this comment.
No we usually remove the versionadded directives when merging up to a new major, so we should stick with this
There was a problem hiding this comment.
The Webhook itself is covered by a 6.3 versionadded in the top of the document.
There was a problem hiding this comment.
Lets do this in the PR of Alex #19268
OskarStark
reviewed
Dec 12, 2023
|
Oh you were fast, just saw your PR. I proposed a different approach, but we can keep your PR as you opened first if you want 🙂 |
OskarStark
force-pushed
the
webhook-6.4
branch
from
92d8c0d to
b8d08cb
Compare
|
Thank you Timo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #19249