[Doctrine] Automapping validation example seems broken #19405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added more field
|
chadyred
changed the title
As the type hinting from setter is available, this example will not work. Even without `declare(strict_types=1);` string which could be convert to integer will work but with it, impossible to run this example, as we will have the error "int" expected.
javiereguiluz
force-pushed
the
patch-5
branch
from
0c8c26a to
12965fa
Compare
|
Thanks Florian! While merging, I did a minor tweak (See ccaf3a1) which I think it was needed to make the example easier to understand. |
|
It sounds good to me, well done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the type hinting from setter is available, this example will not work (and not nullable in that case, it is not possible to run this example with the doc context)
Even without
declare(strict_types=1);string which could be convert to integer will work but with it, impossible to run this example, as we will have the error "int" expected.