Skip to content

[Security] Reword impersonnating event description #19448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

[Security] Reword impersonnating event description #19448

merged 1 commit into from
Jan 23, 2024

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Jan 21, 2024 •
edited by javiereguiluz
Loading

Try fix #19446

  • Replace right after the impersonation is completed by Just before the impersonation is fully completed,
  • Link to event dispatcher (common on other pages)
  • SwitchUserEvent is also dispatched when we exit impersonntion

@carsonbot carsonbot added this to the 7.1 milestone Jan 21, 2024
@alamirault alamirault changed the base branch from 7.1 to 5.4 January 21, 2024 12:45
@alamirault alamirault mentioned this pull request Jan 21, 2024
Closed
@javiereguiluz javiereguiluz modified the milestones: 7.1, 5.4 Jan 23, 2024
@carsonbot carsonbot changed the title Reword impersonnating event description [Security] Reword impersonnating event description Jan 23, 2024
@javiereguiluz javiereguiluz merged commit 9ef80d0 into symfony:5.4 Jan 23, 2024
@javiereguiluz
Copy link
Member

Thanks Antoine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alamirault @javiereguiluz @carsonbot