Skip to content

Update service_decoration.rst #19470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

Exalyon
Copy link
Contributor

@Exalyon Exalyon commented Jan 30, 2024

Fix code example to have attribute above property declaration.

You cannot have an attribute between the visibility and the name of the property

Fix code example to have attribute above property declaration
@carsonbot carsonbot added this to the 6.3 milestone Jan 30, 2024
@Exalyon Exalyon changed the base branch from 6.3 to 6.4 January 30, 2024 19:51
@symfony symfony deleted a comment from carsonbot Jan 31, 2024
@OskarStark OskarStark changed the base branch from 6.4 to 6.3 January 31, 2024 07:21
@OskarStark
Copy link
Contributor

OskarStark commented Jan 31, 2024

Good catch, thanks @Exalyon and congratulations on your first contribution to the Symfony documentation 🎉

@OskarStark OskarStark merged commit de4e978 into symfony:6.3 Jan 31, 2024
@dkarlovi
Copy link
Contributor

@OskarStark would it be possible to have the code examples be extracted and at least linted by a specific tool / command?

Something like

php -> php -l
xml -> ?

etc. IIRC we've discussed that in #18275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants