Skip to content

[AssetMapper] Fixing path #19471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[AssetMapper] Fixing path #19471

merged 1 commit into from
Jan 31, 2024

Conversation

ThomasLandauer
Copy link
Contributor

If the section starts with the pagerfanta CSS, it should use it throughout... :-)

If the section starts with the pagerfanta CSS, it should use it throughout... :-)
@javiereguiluz
Copy link
Member

Good catch, thanks Thomas.

@javiereguiluz javiereguiluz merged commit 2a7880a into symfony:6.4 Jan 31, 2024
@ThomasLandauer ThomasLandauer deleted the patch-6 branch January 31, 2024 10:10
@smnandre
Copy link
Member

Could you revert this PR ? @javiereguiluz @ThomasLandauer

The example of missing path was correct before (a non-bundle package with some asset outside the defined path, and the configuration example followed perfectly the given situation "if you get an error like this..."). I highlighted it in green in the end of this message.

Moreover, this change gives the false impression you may need to register asset path for pagerfanta.

But Pagerfanta, as a bundle with default asset management, does not need to register its path.

It is explained just the paragraph before.


However, if you get an error like this:
+    The "app" importmap entry contains the path "vendor/some/package/assets/foo.js"
    but it does not appear to be in any of your asset paths.
It means that you're pointing to a valid file, but that file isn't in any of
your asset paths. You can fix this by adding the path to your ``asset_mapper.yaml``
file:
.. code-block:: yaml
    # config/packages/asset_mapper.yaml
    framework:
        asset_mapper:
            paths:
                - assets/
+                - vendor/some/package/assets
-                - vendor/babdev/pagerfanta-bundle/Resources/public/css/

OskarStark added a commit that referenced this pull request Feb 14, 2024
This PR was merged into the 6.4 branch.

Discussion
----------

[AssetMapper] Revert " Fixing path"

Reverts #19471

Commits
-------

8be8799 Revert "[AssetMapper] Fixing path"
@OskarStark
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants