Skip to content

[Frontend] Some smaller updates #19473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

ThomasLandauer
Copy link
Contributor

@ThomasLandauer ThomasLandauer commented Jan 31, 2024

  • Please move this page out of the /encore/ hierarchy! This is general info that also applies to any JavaScript. That's why I already changed the title.
  • I removed jQuery cause I think it shouldn't be advertised anymore today.

* **Please move this page out of the `/encore/` structure!** This is general info that also applies to *any* JavaScript.
* I removed jQuery cause I think it shouldn't be advertised anymore today.
@javiereguiluz
Copy link
Member

Thanks Thomas. While merging, I did some minor tweaks to show first the getAttribute() JS method and later, as an alternative, show the dataset property (see df4dafc).

I'm going to move the page as you suggested in a new PR.

@ThomasLandauer ThomasLandauer deleted the patch-6 branch March 19, 2024 11:41
javiereguiluz added a commit that referenced this pull request Mar 21, 2024
…reguiluz)

This PR was merged into the 6.4 branch.

Discussion
----------

[Frontend] Move some page from Encore to Frontend

This finishes #19473 by changing the location of some page from Encore to Frontend because it's a general-purpose page related to JS.

Commits
-------

ea926df [Frontend] Move some page from Encore to Frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants