[Security] Replace a complex table by a list #19674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have an after screenshot? |
|
@OskarStark as you suspected, the original PR looked bad when rendered:
I updated the PR and now it looks like this:
|
|
Much better, love it 👍🏻 |
OskarStark
approved these changes
Mar 16, 2024
javiereguiluz
force-pushed
the
remove_table
branch
from
8adaa2b to
7c2f917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table at https://symfony.com/doc/current/security/access_control.html looks bad because it's very complex:
I propose to replace it by a list of items, which is a very common element in Symfony Docs.