fixed argument order for UniqueEntity #19776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
We can merge this change as it’s not wrong per se, but I think this should also be reported with your IDE as the order does not matter when using named arguments as we do here. |
|
I recently had a similar pull request in symfony/ux. should i ignore this kind of thing in the future? |
|
feel free to still submit this kind of PRs :) |
|
This kind of PR are no fun for maintainers because it can introduce conflicts when merging into newer branches ... but it's true that the underlying problem (the IDE complaining about this) is very annoying. So, let's try to fix some of these issues until we decide that it's too much. Thanks @LtMost! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated parameter order to match order in the constructor to prevent showing a IDE warning.