Skip to content

Prepare 7.2 branch #19915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Prepare 7.2 branch #19915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contributing/code/pull_requests.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ work:
branch (you can find them on the `Symfony releases page`_). E.g. if you
found a bug introduced in ``v5.1.10``, you need to work on ``5.4``.

* ``7.1``, if you are adding a new feature.
* ``7.2``, if you are adding a new feature.

The only exception is when a new :doc:`major Symfony version </contributing/community/releases>`
(5.0, 6.0, etc.) comes out every two years. Because of the
Expand Down
2 changes: 1 addition & 1 deletion contributing/code/tests.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ tests, such as Doctrine, Twig and Monolog. To do so,

.. code-block:: terminal

$ COMPOSER_ROOT_VERSION=7.1.x-dev composer update
$ COMPOSER_ROOT_VERSION=7.2.x-dev composer update

.. _running:

Expand Down
8 changes: 4 additions & 4 deletions setup.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ application:
.. code-block:: terminal

# run this if you are building a traditional web application
$ symfony new my_project_directory --version="7.1.*" --webapp
$ symfony new my_project_directory --version="7.2.*" --webapp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this command and it doesn't work:

❯ symfony new my_project_directory --version="7.2.*" --webapp

In CreateProjectCommand.php line 424:

  Could not find package symfony/skeleton with version 7.2.*.

These other two commands worked as expected:

❯ symfony new my_project_directory --version="7.2.x-dev" --webapp
  Creating a new Symfony 7.2.x-dev project with Composer
  [...]

❯ symfony new my_project_directory --version=next --webapp
  Creating a new Symfony 7.2.x@dev project with Composer
  [...]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you agree on using --version=next here? That way, we wouldn't have to update this in the dev branch of Symfony Docs ... but we'd need to update it back to an specific constraint version whenever a new minor Symfony version is released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end I used 7.2.x-dev because we need to use that in Composer commands (next doesn't work there). This way, we use 7.2.x-dev everywhere and this will be easier to maintain in the future.


# run this if you are building a microservice, console application or API
$ symfony new my_project_directory --version="7.1.*"
$ symfony new my_project_directory --version="7.2.*"

The only difference between these two commands is the number of packages
installed by default. The ``--webapp`` option installs extra packages to give
Expand All @@ -63,12 +63,12 @@ Symfony application using Composer:
.. code-block:: terminal

# run this if you are building a traditional web application
$ composer create-project symfony/skeleton:"7.1.*" my_project_directory
$ composer create-project symfony/skeleton:"7.2.*" my_project_directory
$ cd my_project_directory
$ composer require webapp

# run this if you are building a microservice, console application or API
$ composer create-project symfony/skeleton:"7.1.*" my_project_directory
$ composer create-project symfony/skeleton:"7.2.*" my_project_directory

No matter which command you run to create the Symfony application. All of them
will create a new ``my_project_directory/`` directory, download some dependencies
Expand Down
Loading