[Security] Fix role to detect logged-in user #20240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Sep 20, 2024
security.rst
Outdated
| @@ -2654,7 +2654,7 @@ Secondly, you can use the special "attribute" ``IS_AUTHENTICATED_FULLY`` in plac | |||
|
|
|||
| public function adminDashboard(): Response | |||
| { | |||
| $this->denyAccessUnlessGranted('IS_AUTHENTICATED'); | |||
| $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY'); | |||
There was a problem hiding this comment.
reading the previous paragraph it's rather looks like we should change the sentence before instead to refer to IS_AUTHENTICATED
There was a problem hiding this comment.
I'm sorry but I don't understand...
There was a problem hiding this comment.
There is a paragraph before this code block which should be changed instead of changing the code example.
There was a problem hiding this comment.
Thanks for your reply!
I wasn't sure between IS_AUTHENTICATED and IS_AUTHENTICATED_FULLY.
devojifr
force-pushed
the
security-logged-in-role
branch
from
c034506 to
a867829
Compare
xabbuh
approved these changes
Sep 24, 2024
|
Good catch, thanks @devojifr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error has been introduced since 6.2 when checking to see if a user is logged-in