Missing attribute 'original' #4594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I copy pasted the example messages.en.xliff provided. Running it on symfony 2.6 required me the attribute 'original'. I added ' original="file.ext" ' as attribute for the file tag and it worked. However I am not shure about the proper parameter for this attribute.
wouterj
added a commit
that referenced
this pull request
Dec 6, 2014
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #4594). Discussion ---------- Missing attribute 'original' I copy pasted the example messages.en.xliff provided. Running it on symfony 2.6 required me the attribute 'original'. I added ' original="file.ext" ' as attribute for the file tag and it worked. However I am not shure about the proper parameter for this attribute. Commits ------- c0ef3e4 Missing attribute 'original'
|
Thanks for the fix, marcel! Yeah, we can't have a nice argument for this version due to the translation usage of Symfony: translations don't usually belong to a specific file, but just to the complete application. I've merged it into the 2.3 branch instead of 2.6, as 2.3 is the oldest (still maintained) version of the documentation. Isn't this yet another reason to not promote Xliff usage as the first choice, @fabpot @javiereguiluz @weaverryan? |
|
@wouterj I think you should open an issue about it on the docs with the pros and cons as you see them. Then we can properly talk about it and what a full workflow would be for handling translations - from creating keys, extracting and translating - which is something I also think is missing Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copy pasted the example messages.en.xliff provided. Running it on symfony 2.6 required me the attribute 'original'.
I added ' original="file.ext" ' as attribute for the file tag and it worked. However I am not shure about the proper parameter for this attribute.