Update gmail.rst #5085
Update gmail.rst #5085
Conversation
There are issues with the current docs as they don't address certain user configurations that prevent Symfony from emailing from their app. Mentioning two factor authentication and the less secure app setting is in my opinion, paramount. Reference: http://stackoverflow.com/q/29085617/1188035
|
|
||
| Depending on your Gmail account settings, you may get authentication errors within your app. | ||
| You should ensure two-factor authentication and [also allow less secure apps to access your | ||
| account](https://support.google.com/accounts/answer/6010255) |
There was a problem hiding this comment.
this is markdown syntax, while this docs is writting in reStructured Text. Please update this PR to use that syntax:
.. note::
Depending on your Gmail account settings, you may get authentication errors within your app.
You should ensure two-factor authentication and
`also allow less secure apps to access your account`_.
.. _`also allow less secure apps to access your account`: https://support.google.com/accounts/answer/6010255
|
@sjagr thanks for proposing this improvement! I have a question for you regarding this phrase:
I don't really understand what does it mean. Maybe we could change it for one of these alternatives:
|
Revisions concerning the 2-Step-Verification and correct documentation syntax. Thanks @wouterj and @javiereguiluz
|
Thanks @wouterj for the format corrections. There can be an alternative suggestion of just turning 2-Step-Verification completely off, but I figured a Gmail user with that setting enabled (such as me) would want to leave it on. |
|
This pull request looks finished. If that's true, can we please remove the |
|
|
||
| Depending on your Gmail account settings, you may get authentication errors within your app. | ||
| If your Gmail account uses 2-Step-Verification, you should `generate an App password`_ to use for your | ||
| ``mailer_password`` parameter. |
There was a problem hiding this comment.
There is no need for this line break. Can you also please wrap lines after the first word that crosses the 72nd character instead?
|
I'm finishing this PR in #5430. @sjagr don't worry about not having finished your PR. This happens sometimes. I've taken your work and finished it in another PR. I've also reused all your original commits so you get full credit for your work. Thanks. |
|
Thank you for starting this @sjagr! |
There are issues with the current docs as they don't address certain user configurations that prevent Symfony from emailing from their app. Mentioning two factor authentication and the less secure app setting is in my opinion, paramount.
Reference: http://stackoverflow.com/q/29085617/1188035