service called on wrong variable #5696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -226,7 +226,7 @@ from the authorization checker is called. | |||
|
|
|||
| $authChecker = $this->get('security.authorization_checker'); | |||
|
|
|||
| $this->denyAccessUnlessGranted('view', $post, 'Unauthorized access!'); | |||
| $authChecker->denyAccessUnlessGranted('view', $post, 'Unauthorized access!'); | |||
There was a problem hiding this comment.
this is wrong. the AuthorizationChecker does not have such method
There was a problem hiding this comment.
My bad. But I still don't understand why is service instantiated in this example and then not used.
There was a problem hiding this comment.
it is a left-over of the time when the controller shortcut was not used in the doc.
|
I'll just create another pull request for cleanup... |
|
thank you! please don't forget to reference this PR here |
|
I don't see why we need this PR at all. The issue should be fixed at all when merging #5711, isn't it? |
xabbuh
added a commit
that referenced
this pull request
Sep 23, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #5711). Discussion ---------- removed service call from controller | Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.6, 2.7, 2.8] | Fixed tickets | [] As said in #5696 removed left-over unnecessary service call from controller Commits ------- 42fa416 removed service call from controller
|
@sloba88 Closing here, feel free to reopen if you do not agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.