Skip to content

Update heroku.rst #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update heroku.rst #6750

wants to merge 1 commit into from

Conversation

sherif807
Copy link

changed web: bin/heroku-php-apache2 web/ to web: vendor/bin/heroku-php-apache2 web/

@sherif807
Update heroku.rst
ad8e6e2 
changed web: bin/heroku-php-apache2 web/    to    web: vendor/bin/heroku-php-apache2 web/
@xabbuh
Copy link
Member

xabbuh commented Jul 23, 2016

👍

Status: Reviewed

Note to merger: This should be merged into the 3.0 branch.

@weaverryan
Copy link
Member

Hi @sherif807!

I was about to merge this (because the fix is correct), but I noticed that a little bit more needs to be fixed. Earlier in this section (https://github.com/sherif807/symfony-docs/blob/ad8e6e29e2fd66e94e942ac3b555151d79f9d84e/cookbook/deployment/heroku.rst#1-create-a-procfile) - it says this:

The Composer bin-dir, where vendor binaries (and thus Heroku's own boot scripts) are placed, is bin/ , and not the default vendor/bin.

Obviously, in Symfony 3.0, this is not true! So, can we remove this note? Also, I believe the 2 code-blocks above this change also need to be changed to point to vendor/bin/.. instead of just bin/....

If you agree, could you make those changes?

Status: Needs Work

@javiereguiluz
Copy link
Member

Closing it in favor of #7155. @sherif807 thanks for proposing this fix in the first place!

@javiereguiluz javiereguiluz mentioned this pull request Nov 22, 2016
Merged
xabbuh added a commit that referenced this pull request Nov 22, 2016
@xabbuh
minor #7155 Updated the Heroku deployment article (javiereguiluz)
63696f9 
This PR was merged into the 3.1 branch.

Discussion
----------

Updated the Heroku deployment article

This finishes #6750 with the changes proposed by @weaverryan. I'm pinging @dzuelke to kindly ask him to review of these changes before merging them. Thanks!

Commits
-------

815bb81 Updated the Heroku deployment article
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sherif807 @xabbuh @weaverryan @javiereguiluz @carsonbot