Skip to content

Use ::class whenever it's possible #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Use ::class whenever it's possible #7157

merged 1 commit into from
Nov 28, 2016

Conversation

javiereguiluz
Copy link
Member

No description provided.

@wouterj
Copy link
Member

wouterj commented Nov 22, 2016

👍

A simple grep gives a lot more cases that we can fix: https://gist.github.com/wouterj/ff66784866817e0d6aedafeaa29ffa8a But that doesn't have to be done in this PR imo

status: reviewed

@xabbuh
Copy link
Member

xabbuh commented Nov 22, 2016

@javiereguiluz Do you want to update the other places too?

@javiereguiluz
Copy link
Member Author

@xabbuh I agree with @wouterj and I prefer to do that in a separate PR. Thanks!

@xabbuh
Copy link
Member

xabbuh commented Nov 28, 2016

Thank you Javier.

@xabbuh xabbuh merged commit c270319 into 2.8 Nov 28, 2016
xabbuh added a commit that referenced this pull request Nov 28, 2016
This PR was merged into the 2.8 branch.

Discussion
----------

Use ::class whenever it's possible

Commits
-------

c270319 Use ::class whenever it's possible
@xabbuh xabbuh deleted the improve_forms branch November 28, 2016 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants