Skip to content

remove assetic dic tags. Fix #7274 #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

garak
Copy link
Contributor

@garak garak commented Jan 22, 2017

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Jan 27, 2017

👍

Status: Reviewed

@javiereguiluz
Copy link
Member

@garak I'm sorry but, could you please rebase this to make it mergeable again? Thanks!

@garak garak force-pushed the remove-assetic-dic-tags branch from 2044431 to ca9e5ca Compare July 6, 2017 11:15
@garak
Copy link
Contributor Author

garak commented Jul 6, 2017

Rebased

@HeahDude HeahDude added this to the 3.2 milestone Jul 29, 2017
@HeahDude
Copy link
Contributor

@garak Could you please take care of @xabbuh's comment in #7274? Also this should target 3.2. Thanks!

@javiereguiluz
Copy link
Member

@garak I'm really really sorry but I must close this pull request without merging it. Why? Because we're doing massive changes on all Symfony Docs articles and we've made this very same change as part of the revamp of the frontend articles in #8750. Thanks for understanding it!

@garak garak deleted the remove-assetic-dic-tags branch September 8, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants