Skip to content

Explain how to get all flash messages #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

Alternative to #7430.

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javiereguiluz
Copy link
Member Author

The build on Platform.sh failed. The logs are very long ... but at the end we can find this:

Creating environment 6qmocelev2lwe-pr-7432-tgtexey.
E: Error building the project (we believe it's our fault): Traceback (most recent call last):
     File "/usr/lib/python2.7/dist-packages/gevent_jsonrpc/__init__.py", line 202, in _reader
       obj["id"], obj["method"], obj["params"]
     File "/usr/lib/python2.7/dist-packages/gevent_jsonrpc/__init__.py", line 316, in _execute_method
       return obj(**parameters)
     File "/usr/lib/python2.7/dist-packages/platform_foundation/container/apis/cluster.py", line 52, in create
       cluster.create_as_copy(services, cluster_definition.parent)
     File "/usr/lib/python2.7/dist-packages/protean/proxy.py", line 50, in __call__
       raise ProcessingError(**result["error"])
   ProcessingError: ProcessingError: Exception: Failed to start Container(/root/.hosts/i-8352f4c0/.containers/6qmocelev2lwe-pr-7432-tgtexey--symfonydocs): container died during startup.
   
     File "/usr/lib/python2.7/dist-packages/protean/zookeeper/__init__.py", line 634, in _process_method_call_inner
         result = method.__func__(self._object, *args, **kwargs)
     
       File "/usr/lib/python2.7/dist-packages/platform_foundation/container/__init__.py", line 292, in start
         raise Exception("Failed to start %s: container died during startup." % self)
     
   
     File "/usr/lib/python2.7/dist-packages/protean/zookeeper/__init__.py", line 634, in _process_method_call_inner
         result = method.__func__(self._object, *args, **kwargs)
     
       File "/usr/lib/python2.7/dist-packages/platform_foundation/infrastructure/cluster/__init__.py", line 73, in create_as_copy
         return self.update(services, parent=parent_cluster, create_from_parent=True)
     
       File "/usr/lib/python2.7/dist-packages/protean/object.py", line 179, in __call__
         result = self._method.__func__(self._obj, *args, **kwargs)
     
       File "/usr/lib/python2.7/dist-packages/platform_foundation/infrastructure/cluster/__init__.py", line 190, in update
         return self._update(self.services, operations, parent)
     
       File "/usr/lib/python2.7/dist-packages/platform_foundation/infrastructure/cluster/__init__.py", line 476, in _update
         p.execute()
     
       File "/usr/lib/python2.7/dist-packages/protean/parallel.py", line 65, in execute
         self._result = self._execute()
     
       File "/usr/lib/python2.7/dist-packages/protean/parallel.py", line 143, in _do_one
         result = func(*args, **kwargs)
     
       File "/usr/lib/python2.7/dist-packages/platform_foundation/infrastructure/cluster/__init__.py", line 582, in _execute_service_operation
         service.start()
     
       File "/usr/lib/python2.7/dist-packages/protean/object.py", line 179, in __call__
         result = self._method.__func__(self._obj, *args, **kwargs)
     
       File "/usr/lib/python2.7/dist-packages/platform_foundation/infrastructure/service/__init__.py", line 462, in start
         container.start(self.definition.configuration, self.definition.application)
     
       File "/usr/lib/python2.7/dist-packages/protean/proxy.py", line 50, in __call__
         raise ProcessingError(**result["error"])

@xabbuh
Copy link
Member

xabbuh commented Jan 31, 2017

@javiereguiluz Can you try to trigger a new run of the platform.sh build by rebasing or by making another small change?

@xabbuh
Copy link
Member

xabbuh commented Feb 28, 2017

Thank you Javier.

xabbuh added a commit that referenced this pull request Feb 28, 2017
This PR was squashed before being merged into the 2.7 branch (closes #7432).

Discussion
----------

Explain how to get all flash messages

Alternative to #7430.

Commits
-------

e5c1ed9 Explain how to get all flash messages
@xabbuh xabbuh closed this Feb 28, 2017
xabbuh added a commit that referenced this pull request Mar 1, 2017
…e (javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Fixed the way flash messages are retrieved in the template

In #7432 I changed the code of the templates to get the flash messages. I don't know why I did that ... because it's completely wrong 😵

In #7555 @lerox pointed this issue and I can confirm it:

![symfony_error](https://cloud.githubusercontent.com/assets/73419/23469257/6e423134-fea3-11e6-8d08-e56b01839404.png)

So, let's revert it.

Commits
-------

8ac43ca Fixed the way flash messages are retrieved in the template
xabbuh added a commit that referenced this pull request Mar 3, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

fix usage of the session flag bag API

completes #7432 and #7557

Commits
-------

f050919 fix usage of the session flag bag API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants