Skip to content

Fix Typo $response->setEtag(..) #7478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Typo $response->setEtag(..) #7478

wants to merge 1 commit into from

Conversation

gmorel
Copy link
Contributor

@gmorel gmorel commented Feb 13, 2017

instead of $response->setETag(..)

Keep up the good work !

instead of $response->setETag(..)
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gmorel super nice catch! Thanks.


Beware that in Symfony/Component/HttpFoundation/Response.php the method is: public function setEtag($etag = null, $weak = false)

but in sensio/framework-extra-bundle/Configuration/Cache.php, the method is public function setETag($expression)

Should this inconsistency (setEtag vs setETag) be reported to Symfony?

@xabbuh
Copy link
Member

xabbuh commented Feb 15, 2017

Should this inconsistency (setEtag vs setETag) be reported to Symfony?

@javiereguiluz IMO yes

@javiereguiluz
Copy link
Member

@xabbuh
Copy link
Member

xabbuh commented Feb 19, 2017

Thank you @gmorel.

xabbuh added a commit that referenced this pull request Feb 19, 2017
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7478).

Discussion
----------

Fix Typo $response->setEtag(..)

instead of $response->setETag(..)

Keep up the good work !

Commits
-------

9ce1a77 Fix Typo $response->setEtag(..)
@xabbuh xabbuh closed this Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants