Skip to content

Fixed typo #7502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed typo #7502

wants to merge 1 commit into from

Conversation

KatharinaSt
Copy link
Contributor

Fixed "DoctrieMongoDBMappingsPass" to "DoctrineMongoDBMappingsPass"

@KatharinaSt
Fixed typo
cbe0796 
Fixed "DoctrieMongoDBMappingsPass" to "DoctrineMongoDBMappingsPass"
javiereguiluz
javiereguiluz approved these changes Feb 15, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice catch for a very tricky issue!

Status: reviewed

@KatharinaSt
Copy link
Contributor Author

My pleasure. :-)

@javiereguiluz I noticed it afterwards: Is it true that I should have created my pull request on branch 2.7 (oldest maintained) rather than on 3.2?

@javiereguiluz javiereguiluz changed the base branch from 3.2 to 2.7 February 15, 2017 16:45
@javiereguiluz javiereguiluz changed the base branch from 2.7 to 3.2 February 15, 2017 16:45
@javiereguiluz
Copy link
Member

Note to mergers: this must be merged in 2.7

@KatharinaSt yes, you are right! Typos are fixed in "the oldest branch that contains the error and it's still maintained". so this should go to 2.7 ... but we can change this while merging. Thanks!

@KatharinaSt
Copy link
Contributor Author

@javiereguiluz Thanks for your reply! I'll try to remember next time!

@xabbuh
Copy link
Member

xabbuh commented Feb 19, 2017

Good catch, thanks @KatharinaSt.

@xabbuh xabbuh closed this Feb 19, 2017
xabbuh added a commit that referenced this pull request Feb 19, 2017
@xabbuh
minor #7502 Fixed typo (KatharinaSt)
6f51f90 
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7502).

Discussion
----------

Fixed typo

Fixed "DoctrieMongoDBMappingsPass" to "DoctrineMongoDBMappingsPass"

Commits
-------

210e85e Fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KatharinaSt @javiereguiluz @xabbuh @carsonbot