[SwiftMailer] Update future reference #7510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mykiwi
force-pushed
the
update-swift-mailer
branch
from
e5e29e6 to
4ae12d2
Compare
| @@ -191,6 +225,13 @@ logging | |||
| If true, Symfony's data collector will be activated for Swift Mailer and | |||
| the information will be available in the profiler. | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| The following configuration can used environment variable: | |||
There was a problem hiding this comment.
The following configuration options are compatible with %env()% parameters (with link to doc about them?)
mykiwi
force-pushed
the
update-swift-mailer
branch
2 times, most recently
from
e769f16 to
3b45d89
Compare
mykiwi
force-pushed
the
update-swift-mailer
branch
from
3b45d89 to
287b71f
Compare
xabbuh
reviewed
Feb 18, 2017
|
|
||
| **type**: ``string`` | ||
|
|
||
| The URL to configure swift mailer. |
There was a problem hiding this comment.
"The URL" doesn't look precise enough to me. What about "The URL describing the mail server to connect with"?
javiereguiluz
changed the title
javiereguiluz
approved these changes
Feb 19, 2017
There was a problem hiding this comment.
👍
@mykiwi thanks a lot for this! Your contribution was great, but I've proposed some minor tweaks on top of it. Thanks!
mykiwi
force-pushed
the
update-swift-mailer
branch
from
619f626 to
635a0ab
Compare
fabpot
added a commit
to symfony/swiftmailer-bundle
that referenced
this pull request
Feb 23, 2017
…kiwi)
This PR was merged into the 2.5-dev branch.
Discussion
----------
allow using env variables in transport configuration
Example:
```yml
# MAILER_URL=transport://user:pass@host:port/?encryption=...&auth_mode=...
swiftmailer:
url: "%env(MAILER_URL)%"
```
To do:
- [x] add the doc symfony/symfony-docs/pull/7510
- [x] add tests
Commits
-------
183b291 allow using env variables in transport configuration
HeahDude
reviewed
Feb 27, 2017
| @@ -37,6 +41,15 @@ Configuration | |||
| * `disable_delivery`_ | |||
| * `logging`_ | |||
|
|
|||
| url | |||
| ~~~ | |||
|
|
|||
There was a problem hiding this comment.
Missing version added? (same for other options below)
|
|
||
| **type**: ``string`` | ||
|
|
||
| The entire SwiftMailer configuration using a DSN-like URL format. |
There was a problem hiding this comment.
I think "using" is correct here. We're not saying that Swift "uses" this ... but that the "url" option is all the Swift config using a DSN format.
HeahDude
reviewed
Mar 13, 2017
| @@ -97,20 +100,29 @@ timeout | |||
|
|
|||
| **type**: ``integer`` | |||
|
|
|||
| .. versionadded:: 2.4.2 | |||
| The ``url`` option was added in SwiftMailerBundle 2.4.2. | |||
There was a problem hiding this comment.
The parameter looks wrong here and below.
HeahDude
reviewed
Mar 13, 2017
| The following configuration options are compatible with ``%env()%`` parameters: | ||
| ``url``, ``transport``, ``username``, ``password``, ``host``, | ||
| ``port``, ``timeout``, ``source_ip``, ``local_domain``, | ||
| ``encryption``, ``auth_mode``. |
There was a problem hiding this comment.
Considering symfony/swiftmailer-bundle#159 (comment), we should remove these two parameters for now, wdyt?
HeahDude
approved these changes
Mar 13, 2017
|
Merging it because the related PR was already merged. Thanks Romain! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 28, 2017
…luz) This PR was merged into the master branch. Discussion ---------- [SwiftMailer] Update future reference - [x] Require symfony/swiftmailer-bundle#159 Commits ------- 6aa0117 Removed "encryption" and "auth_mode" from the list of %env()% compatible options 76ce6af Fixed ... again ... the versionadded directives ef7536c Added the missing "versionadded" directives 635a0ab add mail transport as deprecated 54ad41c Minor tweaks 287b71f update swiftmailer reference
xabbuh
added a commit
that referenced
this pull request
May 4, 2017
…uiluz, xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- Backport #7510 for the Symfony 2.7 docs All the documented options are part of SwiftmailerBundle releases that are compatible with Symfony 2.7. Commits ------- 1c39991 fix versionadded directives 8eaccef Removed "encryption" and "auth_mode" from the list of %env()% compatible options 3395258 Fixed ... again ... the versionadded directives 3333723 Added the missing "versionadded" directives 0e2853a add mail transport as deprecated 2bd1a22 Minor tweaks b161bd8 update swiftmailer reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.