Added a note about redirections to absolute URLs in tests #7521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Feb 28, 2017
| @@ -284,8 +284,9 @@ document:: | |||
|
|
|||
| // Assert that the response is a redirect to /demo/contact | |||
| $this->assertTrue( | |||
| $client->getResponse()->isRedirect('/demo/contact'), | |||
| 'response is a redirect to /demo/contact' | |||
| $client->getResponse()->isRedirect('/demo/contact') | |||
There was a problem hiding this comment.
To ease debugging, I learned to favor:
$this->assertSame(Response::HTTP_FOUND, $client->getResponse()->getStatusCode());
$this->assertSame('/demo/contact', $client->getResponse()->headers->get('location'));And since it's very verbose and repetitive I've got a ControllerTestTrait which provides assertions like:
public function assertResponseStatusCode(Client $client, $code)
{
$this->assertSame($code, $client->getResponse()->getStatusCode());
}
public function assertClientIsRedirectedTo(Client $client, $url, $permanent = false)
{
$this->assertResponseStatusCode($client, $permanent ? Response::HTTP_MOVED_PERMANENTLY : Response::HTTP_FOUND);
$this->assertSame($url, $client->getResponse()->headers->get('location'));
}As said in another PR, we need to avoid failure messages like "true is not false" as much as possible to debug faster. Comparing values gives insight immediately.
Maybe it is worth to update the example to advise it, what do you think?
There was a problem hiding this comment.
I'm afraid that's too much for this PR. Even if I agree with your idea (although I use a different implementation) I'd say that change would need a discussion first. Thanks!
There was a problem hiding this comment.
I agree with Javier. Let's keep it as is here.
|
Thank you @javiereguiluz. |
xabbuh
added a commit
that referenced
this pull request
Apr 15, 2017
… (javiereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #7521). Discussion ---------- Added a note about redirections to absolute URLs in tests This fixes symfony/symfony#21189 Commits ------- 8414fb7 Added a note about redirections to absolute URLs in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes symfony/symfony#21189