Updated "Checking for Roles inside a Voter" for 2.8 #7524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one should be easy to review. We're just removing some contents that are not true for 2.8. Thanks! |
HeahDude
reviewed
Apr 15, 2017
security/voters.rst
Outdated
| The solution is to inject the ``service_container`` service and use it to get | ||
| the ``security.authorization_checker`` service and call to the ``isGranted()`` | ||
| method. Another solution is to upgrade your Symfony version, because this issue | ||
| was fixed starting from Symfony 3.1. |
There was a problem hiding this comment.
The linked ticket is mentioning the debug access decision manager introduced in 3.1 but how could this fix the problem of circular dependency for voters requiring the manager? Are we sure this is fixed? Thanks!
There was a problem hiding this comment.
If you remove this note, it should be good to merge.
xabbuh
approved these changes
Nov 7, 2017
|
This will be a tricky one to merge up, but I'll take care of that. Thanks! |
wouterj
added a commit
that referenced
this pull request
Nov 12, 2017
…eguiluz) This PR was squashed before being merged into the 2.8 branch (closes #7524). Discussion ---------- Updated "Checking for Roles inside a Voter" for 2.8 As mentioned in symfony/symfony#21701 this issue was fixed in 3.1 ... so 2.8 still has this issue. Commits ------- ee724b5 Updated "Checking for Roles inside a Voter" for 2.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in symfony/symfony#21701 this issue was fixed in 3.1 ... so 2.8 still has this issue.