Update submit.rst #7772
Update submit.rst #7772
Conversation
Add note that some examples are inherited from ButtonType::class
| @@ -34,6 +34,8 @@ useful when :doc:`a form has multiple submit buttons </form/multiple_buttons>`:: | |||
| Inherited Options | |||
| ----------------- | |||
|
|
|||
| Note some examples come from the ButtonType documentation. If you want to use the SubmitType field, you have to use SubmitType::class instead of ButtonType::class to generate a submit button. | |||
There was a problem hiding this comment.
I would say:
"Note that some examples are inherited from the ButtonType documentation".
Also the use of ::class looks weird here, maybe just replace :: by a space?
|
@DJWindless thanks for making this contribution. I think you found an interesting issue here. Instead of adding this help note as you propose, what do Symfony Doc maintainers think about this other idea: let's not include this help note and let's not show ButtonType examples for SubmitType or ResetType. The wrong include is just a small example. I think it's worth it to duplicate it in the other button type to avoid confusions. |
|
I agree with Javier, let's duplicate this small content. |
|
I agree as well. The contents doesn't change that frequent anyway and it will be less confusing for the reader. |
|
@DJWindless I'm closing your PR in favor of #7824 ... but I thank you for creating this pull request and for forcing us to think about a solution for this issue. Thanks! |
Add note that some examples are inherited from ButtonType::class #6864