Updating Doctrine syntax for getRepository method #7907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meel-io
commented
May 14, 2017
|
|
||
| .. note:: | ||
|
|
||
| The ``AppBundle:Product`` string is a shortcut you can use anywhere | ||
| You can also use ``AppBundle:Product`` syntax. This string is a shortcut you can use anywhere |
There was a problem hiding this comment.
Not sure about this part
There was a problem hiding this comment.
I think it's OK to leave this little note as a reference of how this was used in the past.
|
Thanks for this contribution ... but I'm afraid this change must be done in 2.7 branch. I agree with @xabbuh's comment here: #7892 (comment) |
|
Hi! This is my first contribution so let me know of any mistakes. I'll re-create this PR with 2.7 as base branch. I did that originally so I'll just rollback to the original PR if @weaverryan agrees |
|
Don't worry. We can easily switch the branch while merging (I just tested if there would be any conflicts). |
javiereguiluz
approved these changes
Jul 6, 2017
|
|
||
| .. note:: | ||
|
|
||
| The ``AppBundle:Product`` string is a shortcut you can use anywhere | ||
| You can also use ``AppBundle:Product`` syntax. This string is a shortcut you can use anywhere |
There was a problem hiding this comment.
I think it's OK to leave this little note as a reference of how this was used in the past.
|
I think we need to add a few more Other than that, easy win! |
|
Thank you @meel-io. |
xabbuh
added a commit
that referenced
this pull request
Jul 7, 2017
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #7907). Discussion ---------- Updating Doctrine syntax for getRepository method Changed Doctrine methods to use the `class` constant syntax which is the prefer syntax now. Commits ------- 03224d5 Updating Doctrine syntax for getRepository method
xabbuh
added a commit
that referenced
this pull request
Jul 7, 2017
xabbuh
added a commit
that referenced
this pull request
Jul 7, 2017
* 2.7: [#7907] add some use statements Updating Doctrine syntax for getRepository method Updating doctrine class use [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Added a help note about translating routes Use a safer code sample for Twig best practices Use the Twig namespaced syntax for all templates
xabbuh
added a commit
that referenced
this pull request
Jul 9, 2017
* 2.8: [#7907] add some use statements Updating Doctrine syntax for getRepository method Reworded the tip about property_info and Symfony framework remove useless space Add information for enable property_info service Updating doctrine class use [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Added a help note about translating routes Use a safer code sample for Twig best practices Use the Twig namespaced syntax for all templates Updated the screenshot of deprecation messages
xabbuh
added a commit
that referenced
this pull request
Jul 9, 2017
* 3.2: [#7907] add some use statements Updating Doctrine syntax for getRepository method Reworded the tip about property_info and Symfony framework remove useless space Add information for enable property_info service Updating doctrine class use Fixed the parse() method in the ExpressionLanguage AST examples [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Use "null" so the lock is named automatically Added a help note about translating routes Use a safer code sample for Twig best practices Use the Twig namespaced syntax for all templates Updated the screenshot of deprecation messages Update lockable_trait.rst
xabbuh
added a commit
that referenced
this pull request
Jul 9, 2017
* 3.3: (36 commits) [#7907] add some use statements Updating Doctrine syntax for getRepository method Reworded the tip about property_info and Symfony framework remove useless space Add information for enable property_info service Updating doctrine class use Fixed the parse() method in the ExpressionLanguage AST examples [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Updated the screenshot of exceptions in dev environment Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Use "null" so the lock is named automatically incorrect session short description Use of Setters and Getters Small mistype edits Changed text how to get button label ...
xabbuh
added a commit
that referenced
this pull request
Jul 9, 2017
* 3.4: (23 commits) [#7907] add some use statements Updating Doctrine syntax for getRepository method Reworded the tip about property_info and Symfony framework remove useless space Add information for enable property_info service Updating doctrine class use Fixed the parse() method in the ExpressionLanguage AST examples [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Updated the screenshot of exceptions in dev environment Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Use "null" so the lock is named automatically Added a help note about translating routes Use a safer code sample for Twig best practices Use the Twig namespaced syntax for all templates Updated the screenshot of deprecation messages ...
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Doctrine methods to use the
classconstant syntax which is the prefer syntax now.