[DependencyInjection] Fix decorating service definition #7911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
May 17, 2017
|
Thank you @michaelperrin. |
xabbuh
added a commit
that referenced
this pull request
May 18, 2017
…michaelperrin) This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] Fix decorating service definition There is an error, particularly on the YAML definition where the `decoration_inner_name` option is not defined on the correct service. It should be defined on the decorating service, and not on the decorated service. The XML definition was correct, but was lacking some properties to make things clearer. There PHP definition was not using the correct name of the decorated service. I have fixed the indentation as well on the YAML configuration. Commits ------- dabf122 Fix decorating service definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error, particularly on the YAML definition where the
decoration_inner_nameoption is not defined on the correct service. It should be defined on the decorating service, and not on the decorated service.The XML definition was correct, but was lacking some properties to make things clearer.
There PHP definition was not using the correct name of the decorated service.
I have fixed the indentation as well on the YAML configuration.