Skip to content

[DependencyInjection] Fix decorating service definition #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2017

Conversation

michaelperrin
Copy link
Contributor

There is an error, particularly on the YAML definition where the decoration_inner_name option is not defined on the correct service. It should be defined on the decorating service, and not on the decorated service.

The XML definition was correct, but was lacking some properties to make things clearer.

There PHP definition was not using the correct name of the decorated service.

I have fixed the indentation as well on the YAML configuration.

@xabbuh
Copy link
Member

xabbuh commented May 18, 2017

Thank you @michaelperrin.

@xabbuh xabbuh merged commit dabf122 into symfony:2.7 May 18, 2017
xabbuh added a commit that referenced this pull request May 18, 2017
…michaelperrin)

This PR was merged into the 2.7 branch.

Discussion
----------

[DependencyInjection] Fix decorating service definition

There is an error, particularly on the YAML definition where the `decoration_inner_name` option is not defined on the correct service. It should be defined on the decorating service, and not on the decorated service.

The XML definition was correct, but was lacking some properties to make things clearer.

There PHP definition was not using the correct name of the decorated service.

I have fixed the indentation as well on the YAML configuration.

Commits
-------

dabf122 Fix decorating service definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants