Skip to content

Fix typo #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typo #7995

wants to merge 1 commit into from

Conversation

spbentz
Copy link
Contributor

@spbentz spbentz commented Jun 4, 2017

Unknown "assets_version" function. Did you mean "asset_version"?

@spbentz
Fix typo
317c056 
Unknown "assets_version" function. Did you mean "asset_version"?
@xabbuh xabbuh added this to the 2.7 milestone Jun 4, 2017
javiereguiluz
javiereguiluz approved these changes Jun 4, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The Twig function definition validates this change:

new \Twig_SimpleFunction('asset_version', array($this, 'getAssetVersion')),

@xabbuh
Copy link
Member

xabbuh commented Jun 10, 2017

Thank you @spbentz.

xabbuh added a commit that referenced this pull request Jun 10, 2017
@xabbuh
minor #7995 Fix typo (spbentz)
25cdb5a 
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #7995).

Discussion
----------

Fix typo

Unknown "assets_version" function. Did you mean "asset_version"?

Commits
-------

b951ba8 Fix typo
@xabbuh xabbuh closed this Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@spbentz @xabbuh @javiereguiluz @carsonbot