Update AbstractGuardAuthenticator implementation code to pass curl test according to documentation #7996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the test curl http://localhost:8000/ return this value:
{"message":"Authentication Required"}
instead of
{"message":"Username could not be found."}
Remove anonymous authentication to force digest authentication
|
Hm, we recently made this change (see #7065). |
|
hmm sorry about that, first pull request, I can only see it being corrected in 3.1 and not the above versions |
HeahDude
reviewed
Jun 7, 2017
| @@ -172,8 +172,8 @@ This requires you to implement seven methods:: | |||
| public function getCredentials(Request $request) | |||
| { | |||
| if (!$token = $request->headers->get('X-AUTH-TOKEN')) { | |||
| // No token? | |||
| $token = null; | |||
| // No token? Return null and show "Authentication Required" | |||
There was a problem hiding this comment.
Hello @DaumantasUrb, thank you for this first contribution.
Sadly this change is wrong, another guard can still authenticate this request is this one returning null. If one want to get the exception at this point an exception should be thrown.
Should you we improve the docs so this is better explained?
|
I'm closing because we recently closed another similar pull request that also returned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the test curl http://localhost:8000/ return this value:
{"message":"Authentication Required"}
instead of
{"message":"Username could not be found."}