Update database.rst #8001
Merged
Update database.rst #8001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo: EntityManagerInterface to EntityRepository
xabbuh
reviewed
Jun 6, 2017
| @@ -86,7 +86,7 @@ it's easy to pass a mock object within a test:: | |||
|
|
|||
| // Now, mock the repository so it returns the mock of the employee | |||
| $employeeRepository = $this | |||
| ->getMockBuilder(EntityManagerInterface::class) | |||
| ->getMockBuilder(EntityRepository::class) | |||
There was a problem hiding this comment.
I wonder if we should not mock the ObjectRepository interface instead. We then would even not have to use the disableOriginalConstructor() call.
There was a problem hiding this comment.
I always prefer to makes those kind of changes simultaneously for all existing articles, to avoid differences between articles. Maybe we can open an issue to not forget about that. Thanks!
javiereguiluz
approved these changes
Jul 9, 2017
|
Thank you @Max93. |
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Update database.rst Fix typo: EntityManagerInterface to EntityRepository Commits ------- a3271a2 Update database.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo: EntityManagerInterface to EntityRepository