Reworded the article about slashes in routing placeholders #8020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jun 11, 2017
|
|
||
| .. configuration-block:: | ||
|
|
||
| .. code-block:: php-annotations | ||
|
|
||
| use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route; | ||
|
|
||
| class DemoController | ||
| class DefaultController |
There was a problem hiding this comment.
maybe use something like TokenController then
There was a problem hiding this comment.
Not sure about that. Imagine that this action is for sharing files/folders in Dropbox or sharing photo albums in Google ... and you need the token (hash) of the thing you are sharing. We probably wouldn't call that controller TokenController, but ShareController, FileController, PhotoAlbumController, etc. In these cases, I prefer to keep the neutral DefaultController name to not overcomplicate the examples ... but I'd love to read more opinions about this. Thanks!
weaverryan
approved these changes
Jun 15, 2017
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Jun 18, 2017
…s (javiereguiluz, weaverryan) This PR was merged into the 2.7 branch. Discussion ---------- Reworded the article about slashes in routing placeholders I don't like the original article because the example is not realistic (names can't contain `/`). I also propose to add a note at the end ... but maybe it's unnecessary because all this is too obvious? Commits ------- 71aceb2 minor tweak ec9816b Reworded the article about slashes in routing placeholders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like the original article because the example is not realistic (names can't contain
/).I also propose to add a note at the end ... but maybe it's unnecessary because all this is too obvious?