Skip to content

Clearify setup of basic auth for test environment #8065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2017

Conversation

xelaris
Copy link
Contributor

@xelaris xelaris commented Jun 19, 2017

Fixes #8005

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xelaris thanks for proposing this change. I agree that this is important to note.

However, I think the problem was the original doc. It's better to use 'main' instead of 'your_firewall_name' in the example because we already use 'main' everywhere in the docs. Thanks!

@xabbuh
Copy link
Member

xabbuh commented Jun 22, 2017

Thank you @xelaris.

@xabbuh xabbuh merged commit 5f7c5f6 into symfony:2.7 Jun 22, 2017
xabbuh added a commit that referenced this pull request Jun 22, 2017
…s, javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Clearify setup of basic auth for test environment

Fixes #8005

Commits
-------

5f7c5f6 Minor reword
56488ed Clearify setup of basic auth for test environment
@xelaris xelaris deleted the issue-8005 branch October 31, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants