Fixed typo in workflow.announce event description #8252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good to me (see https://github.com/symfony/symfony/blob/3.2/src/Symfony/Component/Workflow/Workflow.php#L288-L290) |
xabbuh
approved these changes
Aug 2, 2017
javiereguiluz
approved these changes
Aug 2, 2017
|
Good catch, thanks @yann-eugone. |
xabbuh
added a commit
that referenced
this pull request
Aug 29, 2017
…ugone) This PR was merged into the 3.3 branch. Discussion ---------- Fixed typo in workflow.announce event description Maybe I'm wrong but I think that the term `place` is confusing here. I assume that **transitions** are announced. Commits ------- 41b8671 Fixed typo in workflow.announce event description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I'm wrong but I think that the term
placeis confusing here.I assume that transitions are announced.