Skip to content

Update logger service channel name #8256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Update logger service channel name #8256

merged 2 commits into from
Jan 5, 2018

Conversation

dubbs
Copy link
Contributor

@dubbs dubbs commented Aug 3, 2017

This looks like it should be acme instead of app.

@xabbuh
Copy link
Member

xabbuh commented Aug 4, 2017

I think I would change the channel in the config examples to app instead. What do you think?

@HeahDude
Copy link
Contributor

HeahDude commented Aug 5, 2017

Hello @dubbs, good catch for this first contrib.

I agree with @xabbuh, would you like to update your PR accordingly? Thanks!

@dubbs
Copy link
Contributor Author

dubbs commented Aug 7, 2017

Sure, I'll change the example from acme to app.

@javiereguiluz
Copy link
Member

@dubbs we're sorry it took us so long to merge your contribution. We ended up solving it differently, but you discovered and reported the bug, so thank you!

@javiereguiluz javiereguiluz merged commit 7366b2d into symfony:3.3 Jan 5, 2018
javiereguiluz added a commit that referenced this pull request Jan 5, 2018
This PR was merged into the 3.3 branch.

Discussion
----------

Update logger service channel name

This looks like it should be `acme` instead of `app`.

Commits
-------

7366b2d Renamed the channel to "app"
e016a91 Update dic_tags.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants