Skip to content

fix schema_filter example #8282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2017
Merged

fix schema_filter example #8282

merged 1 commit into from
Aug 29, 2017

Conversation

stoccc
Copy link
Contributor

@stoccc stoccc commented Aug 11, 2017

I fixed the schema_filter example, that was wrong.
I set it the same way that is reported in https://symfony.com/doc/current/bundles/DoctrineMigrationsBundle/index.html

I fixed the schema_filter example, that was wrong.
I set it the same way that is reported in https://symfony.com/doc/current/bundles/DoctrineMigrationsBundle/index.html
@xabbuh xabbuh added this to the 2.7 milestone Aug 16, 2017
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep using the / regexp separator instead of ~ because it's more common?

@xabbuh
Copy link
Member

xabbuh commented Aug 29, 2017

Thank you @stoccc.

@xabbuh xabbuh merged commit ab7b0f2 into symfony:2.7 Aug 29, 2017
xabbuh added a commit that referenced this pull request Aug 29, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

fix schema_filter example

I fixed the schema_filter example, that was wrong.
I set it the same way that is reported in https://symfony.com/doc/current/bundles/DoctrineMigrationsBundle/index.html

Commits
-------

ab7b0f2 fix schema_filter example
xabbuh added a commit that referenced this pull request Aug 29, 2017
xabbuh added a commit that referenced this pull request Aug 29, 2017
* 2.7:
  [#8282] fix regex delimiters
  Add missing comment
  validateValue() is deprecated in 3.0
  prefer getObject as getEntity is deprecated
  Update serializer.rst
  [#8308] fix commands order
  Update NotIdenticalTo.rst
  Correct psr/log package name
  Update debugging.rst
  Update group_service_resolver.rst
  Update remember_me.rst
  Update expression_language.rst
  [VarDumper] s/dump.dump_destination/debug.dump_destination/
  fix schema_filter example
  fix form collection label not correct
xabbuh added a commit that referenced this pull request Aug 29, 2017
* 2.8: (21 commits)
  Update resources.rst
  Update events.rst
  Improved a help note about authentication providers
  [#8280] add missing trailing comma
  [#8282] fix regex delimiters
  Add missing comment
  validateValue() is deprecated in 3.0
  prefer getObject as getEntity is deprecated
  Update serializer.rst
  [#8308] fix commands order
  Update NotIdenticalTo.rst
  Correct psr/log package name
  Update debugging.rst
  Update group_service_resolver.rst
  Update remember_me.rst
  Update expression_language.rst
  [VarDumper] s/dump.dump_destination/debug.dump_destination/
  fix schema_filter example
  fix form collection label not correct
  Improved the explanation about the doctrine caching services
  ...
xabbuh added a commit that referenced this pull request Aug 29, 2017
* 3.3: (31 commits)
  Update resources.rst
  Update events.rst
  Improved a help note about authentication providers
  [#8280] add missing trailing comma
  [#8282] fix regex delimiters
  Add missing comment
  Update parameters.rst
  validateValue() is deprecated in 3.0
  prefer getObject as getEntity is deprecated
  Fix non-existing Ldap::find() method
  Fix encore versioning config for SF 4 structure
  Update serializer.rst
  [#8308] fix commands order
  Update NotIdenticalTo.rst
  Correct psr/log package name
  Fixed typo
  Update debugging.rst
  Update group_service_resolver.rst
  Update remember_me.rst
  Update expression_language.rst
  ...
xabbuh added a commit that referenced this pull request Aug 29, 2017
* 3.4: (34 commits)
  Update resources.rst
  Update events.rst
  Improved a help note about authentication providers
  [#8280] add missing trailing comma
  [#8282] fix regex delimiters
  Add missing comment
  Update parameters.rst
  validateValue() is deprecated in 3.0
  prefer getObject as getEntity is deprecated
  Fix non-existing Ldap::find() method
  Fix encore versioning config for SF 4 structure
  Update serializer.rst
  [#8308] fix commands order
  Update NotIdenticalTo.rst
  Correct psr/log package name
  Fixed typo
  Update debugging.rst
  Update group_service_resolver.rst
  Update remember_me.rst
  Update expression_language.rst
  ...
@stoccc stoccc deleted the patch-3 branch May 24, 2018 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants