-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix schema_filter example #8282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed the schema_filter example, that was wrong. I set it the same way that is reported in https://symfony.com/doc/current/bundles/DoctrineMigrationsBundle/index.html
xabbuh
approved these changes
Aug 16, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should keep using the /
regexp separator instead of ~
because it's more common?
Thank you @stoccc. |
xabbuh
added a commit
that referenced
this pull request
Aug 29, 2017
This PR was merged into the 2.7 branch. Discussion ---------- fix schema_filter example I fixed the schema_filter example, that was wrong. I set it the same way that is reported in https://symfony.com/doc/current/bundles/DoctrineMigrationsBundle/index.html Commits ------- ab7b0f2 fix schema_filter example
xabbuh
added a commit
that referenced
this pull request
Aug 29, 2017
xabbuh
added a commit
that referenced
this pull request
Aug 29, 2017
* 2.7: [#8282] fix regex delimiters Add missing comment validateValue() is deprecated in 3.0 prefer getObject as getEntity is deprecated Update serializer.rst [#8308] fix commands order Update NotIdenticalTo.rst Correct psr/log package name Update debugging.rst Update group_service_resolver.rst Update remember_me.rst Update expression_language.rst [VarDumper] s/dump.dump_destination/debug.dump_destination/ fix schema_filter example fix form collection label not correct
xabbuh
added a commit
that referenced
this pull request
Aug 29, 2017
* 2.8: (21 commits) Update resources.rst Update events.rst Improved a help note about authentication providers [#8280] add missing trailing comma [#8282] fix regex delimiters Add missing comment validateValue() is deprecated in 3.0 prefer getObject as getEntity is deprecated Update serializer.rst [#8308] fix commands order Update NotIdenticalTo.rst Correct psr/log package name Update debugging.rst Update group_service_resolver.rst Update remember_me.rst Update expression_language.rst [VarDumper] s/dump.dump_destination/debug.dump_destination/ fix schema_filter example fix form collection label not correct Improved the explanation about the doctrine caching services ...
xabbuh
added a commit
that referenced
this pull request
Aug 29, 2017
* 3.3: (31 commits) Update resources.rst Update events.rst Improved a help note about authentication providers [#8280] add missing trailing comma [#8282] fix regex delimiters Add missing comment Update parameters.rst validateValue() is deprecated in 3.0 prefer getObject as getEntity is deprecated Fix non-existing Ldap::find() method Fix encore versioning config for SF 4 structure Update serializer.rst [#8308] fix commands order Update NotIdenticalTo.rst Correct psr/log package name Fixed typo Update debugging.rst Update group_service_resolver.rst Update remember_me.rst Update expression_language.rst ...
xabbuh
added a commit
that referenced
this pull request
Aug 29, 2017
* 3.4: (34 commits) Update resources.rst Update events.rst Improved a help note about authentication providers [#8280] add missing trailing comma [#8282] fix regex delimiters Add missing comment Update parameters.rst validateValue() is deprecated in 3.0 prefer getObject as getEntity is deprecated Fix non-existing Ldap::find() method Fix encore versioning config for SF 4 structure Update serializer.rst [#8308] fix commands order Update NotIdenticalTo.rst Correct psr/log package name Fixed typo Update debugging.rst Update group_service_resolver.rst Update remember_me.rst Update expression_language.rst ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the schema_filter example, that was wrong.
I set it the same way that is reported in https://symfony.com/doc/current/bundles/DoctrineMigrationsBundle/index.html