Improve routing debug page #8313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atailouloute
force-pushed
the
routing-debug-improvements
branch
from
53f499d to
91724a5
Compare
atailouloute
force-pushed
the
routing-debug-improvements
branch
from
91724a5 to
63498a0
Compare
There was a problem hiding this comment.
@atailouloute thanks for this improvement. However, I'd like to ask some changes:
- The Console Style Guide which changed the look of commands output was introduced in 2.8 (https://symfony.com/blog/new-in-symfony-2-8-console-style-guide) so maybe we shouldn't use it here in 2.7 branch.
- We usually don't document the options of console commands (such as
--show-controllers) because they are hard to maintain in the docs.
In any case, please don't make any change until we know the opinion of the other doc maintainers. Thanks!
|
I agree with Javier on both issues he raised. |
wouterj
approved these changes
Sep 2, 2017
routing/debug.rst
Outdated
| contact_process POST ANY ANY /contact | ||
| article_show ANY ANY ANY /articles/{_locale}/{year}/{title}.{_format} | ||
| blog ANY ANY ANY /blog/{page} | ||
| blog_show ANY ANY ANY /blog/{slug} |
There was a problem hiding this comment.
This should be all indented with 4 spaces, in order for it to be included in the code block defined on line 22.
|
Thanks @atailouloute. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 3, 2018
…luz) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #8313). Discussion ---------- Improve routing debug page Some small improvement for the routing debug doc (http://symfony.com/doc/2.7/routing/debug.html) Commits ------- 6d62d60 Fixes and simplifications 7b2d5d0 Improve routing debug page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small improvement for the routing debug doc (http://symfony.com/doc/2.7/routing/debug.html)