Update phpunit_bridge.rst #8314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$stopwatch->stop('event_name')->getDuration() returns time in milliseconds, so original test will fail in any way.. but not only because of "However, depending on the load of the server or the processes running on your local machine, the $duration could for example be 10.000023s instead of 10s."
javiereguiluz
approved these changes
Aug 30, 2017
HeahDude
approved these changes
Aug 31, 2017
xabbuh
approved these changes
Sep 1, 2017
|
Thank you @temenb. |
xabbuh
added a commit
that referenced
this pull request
Sep 1, 2017
This PR was submitted for the 3.3 branch but it was merged into the 2.8 branch instead (closes #8314). Discussion ---------- Update phpunit_bridge.rst $stopwatch->stop('event_name')->getDuration() returns time in milliseconds, so original test will fail in any way.. but not only because of "However, depending on the load of the server or the processes running on your local machine, the $duration could for example be 10.000023s instead of 10s." Commits ------- 47460b5 Fixed a minor syntax issue afbbfd5 Update phpunit_bridge.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$stopwatch->stop('event_name')->getDuration() returns time in milliseconds, so original test will fail in any way.. but not only because of "However, depending on the load of the server or the processes running on your local machine, the $duration could for example be 10.000023s instead of 10s."