Skip to content

Remove ProgressHelper page #8401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove ProgressHelper page #8401

wants to merge 3 commits into from

Conversation

afurculita
Copy link
Contributor

@afurculita afurculita commented Sep 17, 2017

ProgressHelper is a feature from Symfony 2, removed in Symfony 3. So it can be removed from the docs from Symfony 3.* . This can be merged in 3.0 and after that merged with the other 3.* branches

@wouterj
Copy link
Member

wouterj commented Sep 19, 2017

👍 Agreed! Except that we no longer maintain the 3.0, 3.1 and 3.2 versions of the documention, so we should merge this into 3.3. We can easily switch that during the merge, so you won't have to do anything :)

status: reviewed

@afurculita
Copy link
Contributor Author

@wouterj I know that 3.0 is no longer maintained, but the problem is that SensioLabs offers certification for Symfony 3.0 and when you study for it you need to use the documentation for 3.0. Thus I think 3.0 should still be maintained.

@wouterj
Copy link
Member

wouterj commented Sep 19, 2017

If I understand correctly, SensioLabs offers Symfony 3 certificates. These are about Symfony 3.x, not about 3.0 specifically (some questions can be outdated though). If that's not the case, we should indeed rethink our support process.

(@javiereguiluz please confirm)

@javiereguiluz
Copy link
Member

I'm going to ask internally about this and I'll come back to comment.

@hhamon
Copy link
Contributor

hhamon commented Sep 19, 2017

Hi guys,

The certification is on Symfony 3.0 only!

@xabbuh xabbuh added this to the 3.3 milestone Sep 19, 2017
weaverryan added a commit that referenced this pull request Oct 29, 2017
This PR was squashed before being merged into the 3.3 branch (closes #8402).

Discussion
----------

Remove TableHelper Page

Same argument as in #8401

Commits
-------

0df8c8a Remove TableHelper Page
@weaverryan
Copy link
Member

Just merged #8402 :)

@weaverryan weaverryan closed this Oct 29, 2017
@xabbuh
Copy link
Member

xabbuh commented Nov 2, 2017

@weaverryan But then we should merge this one too, right?

@xabbuh xabbuh reopened this Nov 2, 2017
weaverryan added a commit that referenced this pull request Nov 10, 2017
This PR was submitted for the 3.0 branch but it was merged into the 3.3 branch instead (closes #8401).

Discussion
----------

Remove ProgressHelper page

ProgressHelper is a feature from Symfony 2, removed in Symfony 3. So it can be removed from the docs from Symfony 3.* . This can be merged in 3.0 and after that merged with the other 3.* branches

Commits
-------

cf5ee0b Update index.rst
43461f8 Update redirection_map
431149c Delete progresshelper.rst
@weaverryan
Copy link
Member

Ah, thanks! I was thinking this was a duplicate. I just merged this into 3.3 as well.

@weaverryan weaverryan closed this Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants