Docs re-org and removal of small sections #8537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new-request-re-org: Moving PSR7 into components Removing mime type article and simply moving into reference config TODO - refactoring request article Moving reverse proxies
javiereguiluz
approved these changes
Oct 24, 2017
| request | ||
| ~~~~~~~ | ||
|
|
||
| formats |
There was a problem hiding this comment.
Should we include here the configuration example of the original request/mime_type.rst article?
|
@javiereguiluz I have the same question here as #8538
Will that be automatic? |
|
It's not automatic, but I've removed them in symfony.com repo, so they'll disappear after the next deployment. This is how it'd look:
|
|
Thank you @javiereguiluz! It sounds like we should wait until that deploy, correct? |
weaverryan
added a commit
that referenced
this pull request
Oct 29, 2017
This PR was squashed before being merged into the 2.7 branch (closes #8537). Discussion ---------- Docs re-org and removal of small sections Hi guys! I'd like to have less "Guides" on the left. Some of them only have 1 article or (imo) are not something that's helpful for the user. In this PR, i: 1) Move Assetic out of the top-level and under `frontend`. 2) Removed/moved the Expressions guide 3) Removed/moved the "Request" guides On Symfony.com, we would need to remove the "Assetic", "Expressions" and "Request" guides. All of this content still exists, just somewhere else. The bigger goal is - through a number of PR's - to reduce the number of "guides" links and make sure we have the best links that people will be looking for. Thanks! Commits ------- 678a921 Docs re-org and removal of small sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
I'd like to have less "Guides" on the left. Some of them only have 1 article or (imo) are not something that's helpful for the user. In this PR, i:
frontend.On Symfony.com, we would need to remove the "Assetic", "Expressions" and "Request" guides. All of this content still exists, just somewhere else.
The bigger goal is - through a number of PR's - to reduce the number of "guides" links and make sure we have the best links that people will be looking for.
Thanks!