Updated main configuration guide to Flex #8588
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Nov 3, 2017
configuration.rst
Outdated
|
|
||
| However, a ``.env.dist`` file *is* committed (with dummy values). This file | ||
| isn't read by Symfony: it's just a reference so that Symfony knows which | ||
| parameters need to be defined in the ``.env.dist`` file. If you add or remove |
There was a problem hiding this comment.
need to be defined in the ``.env.dist`` file -> need to be defined in the ``.env`` file ?
configuration.rst
Outdated
|
|
||
| The main configuration file is called ``config.yml``: | ||
| The configuration for a package can be found in ``config/packages``. For |
There was a problem hiding this comment.
can be found in config/packages --> can be found in config/packages/ please always add a trailing slash when referencing directories so the reader never wonders if it's a dir or a file without extension. Thanks!
wouterj
force-pushed
the
flex/configuration
branch
from
117c48d to
5c4f342
Compare
weaverryan
requested changes
Nov 5, 2017
configuration.rst
Outdated
|
|
||
| The main configuration file is called ``config.yml``: | ||
| The configuration for a package can be found in ``config/packages/``. For |
configuration.rst
Outdated
| The configuration has some special top-level keys. One of them is called | ||
| ``parameters``: it's used to define *variables* that can be referenced in *any* | ||
| other configuration file. For example, when installing the *translation* | ||
| package, ``config/services.yaml`` defines a ``locale`` parameter: |
There was a problem hiding this comment.
How about:
For example, when you install the translation package, a
localeparameter is added toconfig/services.yaml:
configuration.rst
Outdated
|
|
||
| However, a ``.env.dist`` file *is* committed (with dummy values). This file | ||
| isn't read by Symfony: it's just a reference so that Symfony knows which | ||
| parameters need to be defined in the ``.env.dist`` file. If you add or remove |
There was a problem hiding this comment.
parameters -> variables (to make it a bit clear that these aren't parameters)
configuration.rst
Outdated
| However, a ``.env.dist`` file *is* committed (with dummy values). This file | ||
| isn't read by Symfony: it's just a reference so that Symfony knows which | ||
| parameters need to be defined in the ``.env.dist`` file. If you add or remove | ||
| keys to ``.env``, add or remove them from ``.env`` too, so both files are |
There was a problem hiding this comment.
the second should be .env.dist.
wouterj
force-pushed
the
flex/configuration
branch
from
5c4f342 to
af92a9e
Compare
|
Ready to merge! |
|
Wooo! Thank you for this BIG pr Wouter! |
weaverryan
added a commit
that referenced
this pull request
Nov 24, 2017
…iluz, weaverryan) This PR was merged into the 4.0 branch. Discussion ---------- Updated the best practice article about config This was the only remaining article to be updated in "Best Practices". Related to this: * The main config.rst is being updated in ~~#8588~~ * Some config/* articles are being updated in ~~#8647~~. * I'm going to update the rest of config/* articles. Commits ------- 175a4e8 minor tweaks b973f0c Updated the best practice article about config
weaverryan
added a commit
that referenced
this pull request
Dec 1, 2017
This PR was squashed before being merged into the 4.0 branch (closes #8592). Discussion ---------- [Flex] Update routing & controller chapters More progress in updating all of the "Getting Started" guides. I will next do templating, configuration (though this has been done in #8588) and also `service_container`, which I'd like to move into Getting Started. Commits ------- 0cbbc28 fixing build errors 7f0163a tweaks 10563a9 Proofing the controller chapters 44f2ff8 more work on getting started docs 218e2d4 WIP controller chapter 8b923e6 WIP controller changes 89d56ea Updating routing for Flex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.