Skip to content

fix paths in testing/bootstrap.rst #8605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

boedah
Copy link
Contributor

@boedah boedah commented Nov 8, 2017

  • comment said app/tests.bootstrap.php but xml referenced the root
  • path to autoload was wrong
  • Symfony console now is in /bin

* comment said `app/tests.bootstrap.php` but xml referenced the root
* path to autoload was wrong
* Symfony console now is in `/bin`
@yceruto
Copy link
Member

yceruto commented Nov 8, 2017

Probably this article should be refactored entirely to adapt to 3.3 structure https://github.com/symfony/symfony-standard/tree/3.3

For example, this test.boostrap.php file could live inside tests/ directory and would be named bootstrap.php. Also I'm not sure whether the if statement is really necessary or not.

wouterj added a commit that referenced this pull request Nov 12, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

fix paths in testing/bootstrap.rst

* comment said `app/tests.bootstrap.php` but xml referenced the root
* path to autoload was wrong
* Symfony console now is in `/bin`

Commits
-------

e075514 fix paths
@wouterj
Copy link
Member

wouterj commented Nov 12, 2017

Good work @boedah! This article was indeed not completely correct...

I've merged your PR, and then changed stuff a little more in a7d8d97 . The main change here is moving this bootstrap file to tests/bootstrap.php, which I think is a nicer location.

Thanks!

@wouterj wouterj closed this Nov 12, 2017
weaverryan added a commit that referenced this pull request Nov 12, 2017
* 3.3:
  Added Best Practice guideline for partials/include
  Backporting #8600
  [#8605] Updated the article a little more, using the tests/ directory.
  fix paths
  Move `schema_filter` option to the correct place
  Fix typo in "advanced ACL concepts"
  Add special Abstract prefix not usage for PHPUnit test cases
weaverryan added a commit that referenced this pull request Nov 12, 2017
* 3.4:
  Added Best Practice guideline for partials/include
  Backporting #8600
  [#8605] Updated the article a little more, using the tests/ directory.
  fix paths
  Move `schema_filter` option to the correct place
  Fix typo in "advanced ACL concepts"
  Add special Abstract prefix not usage for PHPUnit test cases
@boedah boedah deleted the patch-1 branch November 13, 2017 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants