Updated the bundle configuration articles to Symfony 4 #8620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Nov 12, 2017
bundles/configuration.rst
Outdated
| @@ -46,13 +47,13 @@ as integration of other related components: | |||
| .. sidebar:: Using Parameters to Configure your Bundle | |||
|
|
|||
| If you don't have plans to share your bundle between projects, it doesn't | |||
There was a problem hiding this comment.
Haha, yea, I agree with Wouter. We can still say this is optional, of course, but if you're reading this, then you do want to share your bundle between projects :)
There was a problem hiding this comment.
You are completely right! This only made sense in the past, where bundles could be non-shareable ... but that's no longer the case. Removed the entire sidebar!
weaverryan
approved these changes
Nov 12, 2017
bundles/configuration.rst
Outdated
| @@ -46,13 +47,13 @@ as integration of other related components: | |||
| .. sidebar:: Using Parameters to Configure your Bundle | |||
|
|
|||
| If you don't have plans to share your bundle between projects, it doesn't | |||
There was a problem hiding this comment.
Haha, yea, I agree with Wouter. We can still say this is optional, of course, but if you're reading this, then you do want to share your bundle between projects :)
|
One minor comment + fix the conflict. Then we can merge! |
javiereguiluz
force-pushed
the
bundle_config
branch
from
25ebe7c to
1479c71
Compare
|
Thank you Javier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.