Skip to content

Removing bundle removing article #8681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Removing bundle removing article #8681

merged 1 commit into from
Nov 16, 2017

Conversation

weaverryan
Copy link
Member

We already removed the "Bundle Installation" document for 4.0. I think removing the "removing" bundle should also be done. This article adds very-little value, and even less value in the world of Flex.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if it may be a bit early to do that ... but I think it's OK. Even if you know nothing, removing a bundle is simple: you execute composer remove ... and if you forgot to update bundles.php, you'll see a clear error and if you forget to remove the bundle config, you'll see a clear error too.

@xabbuh xabbuh added this to the 4.0 milestone Nov 16, 2017
@xabbuh
Copy link
Member

xabbuh commented Nov 16, 2017

Thank you @weaverryan.

@xabbuh xabbuh merged commit 9f32377 into symfony:master Nov 16, 2017
xabbuh added a commit that referenced this pull request Nov 16, 2017
This PR was merged into the master branch.

Discussion
----------

Removing bundle removing article

We already removed the "Bundle Installation" document for 4.0. I think removing the "removing" bundle should also be done. This article adds very-little value, and even less value in the world of Flex.

Commits
-------

9f32377 removing bundle removing article
@xabbuh
Copy link
Member

xabbuh commented Nov 16, 2017

remaining references to this document removed in 333a921 and d53d72a

@weaverryan weaverryan deleted the remove-bundle-remove branch November 17, 2017 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants