Skip to content

Fix server configuration for Symfony 4 #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michaelperrin
Copy link
Contributor

@michaelperrin michaelperrin commented Nov 18, 2017

I started this PR from #8679 to add more fixes to it.

There is still one thing that is not correct, about .htaccess files that Symfony 4 doesn't provide anymore. This should be part of an other PR (and maybe create a recipe to create these files, I will look into it).

@michaelperrin michaelperrin changed the title Fix server configuration for Symfony 4 [WIP] Fix server configuration for Symfony 4 Nov 18, 2017
@michaelperrin michaelperrin force-pushed the fix/symfony4-server-configuration branch from 2a5369c to d343c01 Compare November 18, 2017 11:11
@michaelperrin michaelperrin changed the title [WIP] Fix server configuration for Symfony 4 Fix server configuration for Symfony 4 Nov 18, 2017
@michaelperrin
Copy link
Contributor Author

It's not really part of the server configuration, but we should also update the http://symfony.com/doc/master/configuration/override_dir_structure.html article (which deals with the web dir as well).

@weaverryan weaverryan changed the base branch from master to 4.0 November 21, 2017 20:02
@weaverryan weaverryan added this to the 4.0 milestone Nov 21, 2017
@javiereguiluz javiereguiluz mentioned this pull request Nov 21, 2017
12 tasks
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I've added a separate issue about Apache and also linked to your comment about overriding the directory structure from another issue.

@weaverryan
Copy link
Member

Thank you Michaël!

@weaverryan weaverryan merged commit d343c01 into symfony:4.0 Nov 21, 2017
weaverryan added a commit that referenced this pull request Nov 21, 2017
…perrin)

This PR was merged into the 4.0 branch.

Discussion
----------

Fix server configuration for Symfony 4

I started this PR from #8679 to add more fixes to it.

There is still one thing that is not correct, about `.htaccess` files that Symfony 4 doesn't provide anymore. This should be part of an other PR (and maybe create a recipe to create these files, I will look into it).

Commits
-------

d343c01 Update server configuration for Symfony 4
2ee2ce2 Change web directory with public directory
@michaelperrin
Copy link
Contributor Author

Thanks @weaverryan! More to come soon 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants