[yaml] Fix !php/* tag should not contain : at the end for Symfony 4
#8698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the [upgrade guide](https://github.com/symfony/symfony/blob/master/UPGRADE-4.0.md): > The !php/object: tag was removed in favor of the !php/object tag (without the colon). > The !php/const: tag was removed in favor of the !php/const tag (without the colon).
javiereguiluz
approved these changes
Nov 20, 2017
There was a problem hiding this comment.
Nice! Jérôme, thanks for fixing this.
@xabbuh please review if this change was made only for Symfony 4 or also for Symfony 3.4. Thanks!
xabbuh
requested changes
Nov 21, 2017
components/yaml.rst
Outdated
| @@ -243,7 +243,7 @@ You can dump objects by using the ``DUMP_OBJECT`` flag:: | |||
| $object->foo = 'bar'; | |||
|
|
|||
| $dumped = Yaml::dump($object, 2, 4, Yaml::DUMP_OBJECT); | |||
| // !php/object:O:8:"stdClass":1:{s:5:"foo";s:7:"bar";} | |||
| // !php/object O:8:"stdClass":1:{s:5:"foo";s:7:"bar";} | |||
There was a problem hiding this comment.
this should be // !php/object 'O:8:"stdClass":1:{s:3:"foo";s:3:"bar";}'
components/yaml.rst
Outdated
| @@ -269,7 +269,7 @@ By default the parser will encode invalid types as ``null``. You can make the | |||
| parser throw exceptions by using the ``PARSE_EXCEPTION_ON_INVALID_TYPE`` | |||
| flag:: | |||
|
|
|||
| $yaml = '!php/object:O:8:"stdClass":1:{s:5:"foo";s:7:"bar";}'; | |||
| $yaml = '!php/object O:8:"stdClass":1:{s:5:"foo";s:7:"bar";}'; | |||
There was a problem hiding this comment.
should be $yaml = '!php/object \'O:8:"stdClass":1:{s:3:"foo";s:3:"bar";}\'';
|
3.4 is correct, the old example won't work with Symfony 4, but the tag with colon is already deprecated in 3.4 |
xabbuh
approved these changes
Nov 21, 2017
|
@xabbuh Changes done |
|
Thank you Jérôme! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the upgrade guide: