Updated testing/* articles to Symfony 4 #8705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Nov 20, 2017
testing.rst
Outdated
| To run your functional tests, the ``WebTestCase`` class needs to know which | ||
| is the application kernel to bootstrap it. The kernel class is usually | ||
| defined in the ``KERNEL_CLASS`` environment variable (included in the | ||
| default ``phpunit .xml-dist`` file provided by Symfony): |
testing.rst
Outdated
|
|
||
| .. code-block:: xml | ||
|
|
||
| <?xml version="1.0" charset="utf-8" ?> | ||
| <phpunit> | ||
| <php> | ||
| <server name="KERNEL_DIR" value="/path/to/your/app/" /> | ||
| <!-- the value is the FQCN of the application kernel --> | ||
| <server name="KERNEL_CLASS" value="App\Kernel" /> |
There was a problem hiding this comment.
now should be <env ... />? https://github.com/symfony/recipes/blob/master/phpunit/phpunit/4.7/phpunit.xml.dist#L12
testing/database.rst
Outdated
| dbname: testdb | ||
| user: testdb | ||
| password: testdb | ||
| url: 'mysql://USERNAME:[email protected]/DB_NAME?charset=utf8mb4&serverVersion=5.7' |
There was a problem hiding this comment.
As Doctrine configuration has defined an environment variable '%env(resolve:DATABASE_URL)%' for all env, I guess we should do the changes in phpunit.xml.dist file, adding <env name="DATABASE_URL" value="..."/>? then this whole configuration will be gone.
There was a problem hiding this comment.
Much better. Thanks!
This was referenced Nov 20, 2017
weaverryan
added a commit
that referenced
this pull request
Nov 21, 2017
weaverryan
added a commit
that referenced
this pull request
Nov 21, 2017
…uiluz) This PR was merged into the 3.3 branch. Discussion ---------- Removed a deprecated feature in a testing article Spotted while working on #8705. This is no longer needed because all profiler storage engines were removed: https://symfony.com/doc/current/profiler/storage.html Commits ------- eb30e13 Removed a deprecated feature in a testing article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.