Doctrine update for Flex #8729

weaverryan · 2017-11-21T21:10:46Z

Hi guys!

This is an update to 4.0. But... I basically rewrote the main doctrine.rst page and also doctrine/associations.rst. All the rest is just a simple directory structure update. I made many changes, but I DID code through all of them, so we don't need to review the code for "will this actually work?" type of stuff :).

verify that the section where we talk about "line 12 does this" is still accurate to the lines

yceruto · 2017-11-22T20:39:22Z

doctrine.rst

             */
            private $id;

            /**
-             * @ORM\Column(type="string", length=100)
+             * @ORM\Column(type="string", length=100, nullable=false)


it is nullable=false by default for @ORM\Column annotation.

yceruto · 2017-11-22T20:46:13Z

doctrine.rst

+    Be careful not to use reserved SQL keywords as your table or column names
+    (e.g. ``GROUP`` or ``USER``). See Doctrine's `Reserved SQL keywords documentation`_
+    for details on how to escape these. Or, configure the table name with
+    ``@ORM\Table(name="groups")`` or the column name with the ``name="group_name"``


what about to show directly how to escape keywords here? @ORM\Table(name="`group`") or the column name with the name="`group`"

yceruto · 2017-11-22T20:56:39Z

doctrine.rst


-.. tip::
+    // ...
+    class ProductRepository extends ServiceEntityRepository


if we are extending from ServiceEntityRepository shouldn't assume that this class is intended to be a service and autowired? if yes, we might need the __constructor to set the entityClass?

yceruto · 2017-11-22T20:58:22Z

doctrine.rst

+            ORDER BY p.price ASC
+            ';
+        $stmt = $conn->prepare($sql);
+        $stmt->execute(array('price' => 10));


yceruto · 2017-11-22T21:00:06Z

doctrine/associations.rst

-             * @ORM\ManyToOne(targetEntity="Category", inversedBy="products")
-             * @ORM\JoinColumn(name="category_id", referencedColumnName="id")
+             * @ORM\ManyToOne(targetEntity="App\Entity\Category", inversedBy="products")
+             * @ORM\JoinColumn(nullable=true)


it isnullable=true by default for @ORM\JoinColumn annotation.

Yea... but I do want it to be nullable (it just makes the example easier, no error in case you already have Products in the database) but I also want to show this option so that people are thinking about it.

weaverryan · 2017-11-24T01:24:37Z

This is ready for review!

yceruto

Great!! I loved every change :)

yceruto · 2017-11-24T04:29:59Z

doctrine/associations.rst

@@ -301,24 +335,24 @@ What's important is the fact that you have easy access to the product's related
 category, but the category data isn't actually retrieved until you ask for
 the category (i.e. it's "lazily loaded").

-You can also query in the other direction::
+Because we mapped the optiona ``OneToMany`` side, you can also query in the other


javiereguiluz

Great changes and simplifications. Thanks!

javiereguiluz · 2017-11-24T07:43:02Z

doctrine.rst

-    We recommend against MySQL's ``utf8`` character set, since it does not
-    support 4-byte unicode characters, and strings containing them will be
-    truncated. This is fixed by the `newer utf8mb4 character set`_.
+There are more optiosn in ``config/packages/doctrine.yaml`` that you can configure,


optiosn -> options

javiereguiluz · 2017-11-24T07:45:00Z

doctrine.rst

-                ),
-            ));
+    There are many other Doctrine commands. To see a full list, run
+    ``php bin/console list doctrine``.


The . after a command is always troublesome because some people will add it when executing it. We could change the order in this phrase to avoid the dot:

Run ``php bin/console list doctrine`` to see the full list.

javiereguiluz · 2017-11-24T07:46:15Z

doctrine.rst

        }

    .. code-block:: yaml

-        # src/Resources/config/doctrine/Product.orm.yml
+        # config/doctrine/Product.orm.yml


Are we sure this new path works as expected? I'd love to because it's much better!

Yeah, it can be configurable too:

doctrine: orm: # ... mappings: App: is_bundle: false type: yml dir: '%kernel.project_dir%/config/doctrine' # <--- custom path prefix: 'App\Entity' alias: App

In fact, you must add the config that @yceruto showed for this to work.

javiereguiluz · 2017-11-24T07:49:34Z

doctrine.rst

-.. note::
+Doctrine supports a wide variety of different field types, each with their own options.
+To see a full list of types and options, see `Doctrine's Mapping Types documentation`_.
+If you want to use ``xml`` instead of annotations, you'll need to configure this in your


In this phrase -> "If you want to use xml instead of annotations, you'll need to configure this in your config/packages/doctrine.yaml file." the part about "... you'll need to configure this ..." to me means that you are going to show me now what should I configure. Not sure if I explained my self, but something like this could be more clear:

If you want to use XML instead of annotations, add ``type: xml`` to the entity mappings in your ``config/packages/doctrine.yaml`` file.

javiereguiluz · 2017-11-24T08:38:42Z

doctrine.rst


-    If you're following along with this example, you'll need to create a
-    route that points to this action to see it work.
+Congratulations! You just created your first row the ``product`` table. To prove it,


your first row the -> your first row IN the

javiereguiluz · 2017-11-24T08:41:13Z

doctrine.rst

-        WHERE p.price > :price
-        ORDER BY p.price ASC'
-    )->setParameter('price', 19.99);
+When you fetch your repository (i.e. ``->getRepository(Product::class)``, it is


The parenthesis of (i.e. .. is lacking a closing parenthesis.

javiereguiluz · 2017-11-24T08:42:51Z

doctrine/dbal.rst

-                charset:  UTF8
-                server_version: 5.6
+    # customize this line!
+    DATABASE_URL="mysql://db_user:[email protected]:3306/db_name?charset=utf8mb4&serverVersion=5.7"


Should charset=utf8mb4&serverVersion=5.7 be removed in this DATABASE_URL env var?

Good catch!

@yceruto

This PR was squashed before being merged into the 4.0 branch (closes #8729). Discussion ---------- Doctrine update for Flex Hi guys! This is an update to 4.0. But... I basically rewrote the main `doctrine.rst` page and also `doctrine/associations.rst`. All the rest is just a simple directory structure update. I made many changes, but I DID code through all of them, so we don't need to review the code for "will this actually work?" type of stuff :). * [ ] verify that the section where we talk about "line 12 does this" is still accurate to the lines Commits ------- 39c4a83 fixes thanks to the team! 04603c7 Fixing build problems 59c6b0d tweaks thanks to @yceruto 2b0236f updating the rest of the Doctrine docs 68ac454 WIP - updating associations article 7e77d9c moving section down 6259931 Finishing major overhaul of the main Doctrine chapter 4938678 WIP - starting to upgrade Doctrine doc

WIP - starting to upgrade Doctrine doc

4938678

carsonbot added the Status: Needs Review label Nov 21, 2017

weaverryan added 3 commits November 22, 2017 14:24

Finishing major overhaul of the main Doctrine chapter

6259931

moving section down

7e77d9c

WIP - updating associations article

68ac454

yceruto reviewed Nov 22, 2017

View reviewed changes

updating the rest of the Doctrine docs

2b0236f

weaverryan changed the title ~~[WIP] Doctrine update for Flex~~ Doctrine update for Flex Nov 24, 2017

weaverryan added 2 commits November 23, 2017 20:18

tweaks thanks to @yceruto

59c6b0d

Fixing build problems

04603c7

weaverryan added this to the 4.0 milestone Nov 24, 2017

yceruto approved these changes Nov 24, 2017

View reviewed changes

javiereguiluz approved these changes Nov 24, 2017

View reviewed changes

javiereguiluz mentioned this pull request Nov 26, 2017

Updating docs to Symfony 4 and Symfony Flex #8754

Closed

fixes thanks to the team!

39c4a83

weaverryan merged commit 39c4a83 into symfony:4.0 Nov 27, 2017

Uh oh!

Doctrine update for Flex #8729

Doctrine update for Flex #8729

Uh oh!

Conversation

weaverryan commented Nov 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weaverryan commented Nov 24, 2017

Uh oh!

yceruto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

javiereguiluz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

weaverryan commented Nov 21, 2017 •

edited

Loading